Introduce stake jobs batching and delayed execution by shamil-gadelshin · Pull Request #1525 · opentensor/subtensor

shamil-gadelshin · 2025-04-10T15:12:04Z

Description

This PR introduces changes to stake-related extrinsics (starting with add_stake). The goal is to address MeV behavior by aggregating stake operations into batches according to their type before executing, thus removing the possibility of the "sandwich" MeV.

The PR introduces a new storage map (StakeJobs) which accumulates the stake operations (jobs) during the extrinsic calling. Those jobs will be executed during the on_finalize() call in the end of the block.

Related Issue(s)

Closes Anti-MEV aggregation #1509

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Other (please describe):

Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

Additional Notes

The extrinsic contains parts of the code behind the runtime-benchmark feature to enable the correct weight calculation considering the on_finalize() code.

shamil-gadelshin · 2025-04-10T15:13:03Z

Some comments, as well as the benchmarking code, are missing. I will add those after the initial review.

Extrinsics: - add_stake_aggregate - remove_stake_aggregate

shamil-gadelshin · 2025-04-15T09:56:27Z

Recent changes

new extrinsics remove_stake_aggregate, remove_stake_aggregate_limit, add_stake_aggregate_limit
more tests, including crucial stake job ordering test
benchmarks for add_stake_aggregate, remove_stake_aggregate
updates for SignedExtension
updates for InstanceFilter for ProxyType

Additional notes

CallType enum and usage was not modified (also original add_stake_limit and remove_stake_limit weren't present there also)
Weights for add_stake_limit_aggregate and remove_stake_limit_aggregate were copied from add_stake_aggregate and remove_stake_aggregate similar to their originals. The new benchmarks for the remaining two extrinsics will be created in a separate PR.

pallets/subtensor/src/lib.rs

Co-authored-by: Loris Moulin <45130584+l0r1s@users.noreply.github.com>

l0r1s · 2025-04-15T10:57:24Z

pallets/subtensor/src/staking/add_stake.rs

+        if cfg!(feature = "runtime-benchmarks") {
+            Self::stake_into_subnet(
+                &hotkey,
+                &coldkey,
+                netuid,
+                tao_staked.saturating_to_num::<u64>(),
+                fee,
+            );
+        }


Nice way to handle it 👍

pallets/subtensor/src/staking/remove_stake.rs

Co-authored-by: Loris Moulin <45130584+l0r1s@users.noreply.github.com>

shamil-gadelshin · 2025-04-15T13:32:58Z

The last changes introduce aggregated stake events and move "alpha decrease" operation back to extrinsics.

l0r1s

👍

pallets/subtensor/src/macros/dispatches.rs

pallets/subtensor/src/staking/add_stake.rs

pallets/subtensor/src/staking/remove_stake.rs

pallets/subtensor/src/tests/mock.rs

l0r1s

Mostly nits about missing doc, lgtm 👍

shamil-gadelshin

I copied the original doc comments with that error. Thanks for the review. I changed the original doc comments as well.

pallets/subtensor/src/tests/mock.rs

Introduce add_stake_aggregate extrinsic

2ff555c

shamil-gadelshin added 7 commits April 11, 2025 13:03

Introduce ‘remove_stake_aggregate` extrinsic.

b9ca2ca

Introduce add_stake_limit_aggregate extrinsic.

0f7d322

Introduce remove_stake_aggregate extrinsic.

125ca32

Add aggregate stake extrinsics ordering test.

2ad53e7

Add aggregate staking benchmarks.

5e49fae

Extrinsics: - add_stake_aggregate - remove_stake_aggregate

Update SignedExtension for new extrinsics

82f18bf

Update InstanceFilter<RuntimeCall> for ProxyType

9f87e12

shamil-gadelshin added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 15, 2025

shamil-gadelshin marked this pull request as ready for review April 15, 2025 09:56

shamil-gadelshin marked this pull request as draft April 15, 2025 10:08

Fix format.

1e9bc82

l0r1s reviewed Apr 15, 2025

View reviewed changes

pallets/subtensor/src/lib.rs Show resolved Hide resolved

l0r1s reviewed Apr 15, 2025

View reviewed changes

pallets/subtensor/src/lib.rs Outdated Show resolved Hide resolved

l0r1s reviewed Apr 15, 2025

View reviewed changes

pallets/subtensor/src/lib.rs Outdated Show resolved Hide resolved

Update extrinsics with additional conditions for test environment.

27bf982

shamil-gadelshin marked this pull request as ready for review April 15, 2025 10:42

Update pallets/subtensor/src/lib.rs

a980c9d

Co-authored-by: Loris Moulin <45130584+l0r1s@users.noreply.github.com>

l0r1s reviewed Apr 15, 2025

View reviewed changes

pallets/subtensor/src/staking/remove_stake.rs Outdated Show resolved Hide resolved

shamil-gadelshin and others added 3 commits April 15, 2025 15:03

Update pallets/subtensor/src/staking/remove_stake.rs

86916d1

Co-authored-by: Loris Moulin <45130584+l0r1s@users.noreply.github.com>

Introduce events for aggregated stakes.

560a95a

Move alpha decreasing back to extrinsics.

f95774e

Merge remote-tracking branch 'origin/devnet-ready' into aggregate-stakes

83aaaf4

sam0x17 requested a review from l0r1s April 15, 2025 15:50

l0r1s previously approved these changes Apr 15, 2025

View reviewed changes

camfairchild added the breaking-change This PR introduces a noteworthy breaking change label Apr 15, 2025

shamil-gadelshin requested review from l0r1s and sam0x17 April 23, 2025 09:30