Introduce ZeroMaxAmount error for add_stake_limit extrinsic.#1577
Merged
sam0x17 merged 8 commits intodevnet-readyfrom May 5, 2025
Merged
Introduce ZeroMaxAmount error for add_stake_limit extrinsic.#1577sam0x17 merged 8 commits intodevnet-readyfrom
sam0x17 merged 8 commits intodevnet-readyfrom
Conversation
Contributor
|
@opentensor/cerebrum / @opentensor/gyrus / @opentensor/cortex breaking change detected! Please prepare accordingly! |
Collaborator
Author
|
The recent changes refactor |
Collaborator
Author
|
The recent changes update the benchmark version to V2. |
camfairchild
reviewed
May 2, 2025
| CustomTransactionError::ServingRateLimitExceeded => 12, | ||
| CustomTransactionError::InvalidPort => 13, | ||
| CustomTransactionError::BadRequest => 255, | ||
| CustomTransactionError::ZeroMaxAmount => 14, |
camfairchild
previously approved these changes
May 2, 2025
l0r1s
reviewed
May 5, 2025
l0r1s
previously approved these changes
May 5, 2025
l0r1s
approved these changes
May 5, 2025
sam0x17
approved these changes
May 5, 2025
gztensor
approved these changes
May 5, 2025
This was referenced May 8, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was possible to have a successful
add_stake_limitextrinsic with zero stake added. This PR fixes this error.Here is the example: https://taostats.io/extrinsic/5338471-0009?network=finney
Related Issue(s)
Type of Change
Breaking Change
The PR introduces a new possible error.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyAdditional Notes
move_stakeextrinsic shares the same logicget_max_amount_addwithin itsget_max_amount_movemethod but the PR kept the previous logic.