Introduce SameSubnetId error for move and swap stake extrinsics.#1588
Merged
sam0x17 merged 4 commits intodevnet-readyfrom May 7, 2025
Merged
Introduce SameSubnetId error for move and swap stake extrinsics.#1588sam0x17 merged 4 commits intodevnet-readyfrom
sam0x17 merged 4 commits intodevnet-readyfrom
Conversation
sam0x17
previously approved these changes
May 6, 2025
camfairchild
suggested changes
May 6, 2025
sam0x17
approved these changes
May 6, 2025
l0r1s
approved these changes
May 7, 2025
JohnReedV
approved these changes
May 7, 2025
sam0x17
approved these changes
May 7, 2025
This was referenced May 8, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
SameSubnetIderror for all extrinsics related to moving stake (move, stake, and their versions with limits). The change was introduced in the shared inner methodvalidate_stake_transition. The new code prevents the stake from moving for the same origin and destination subnets for the same coldkey and hotkey. The PR also changes tests and related benchmarks.Type of Change
Breaking Change
The PR introduces a new error for the same subnets, coldkeys, and hotkeys.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly