Skip to content

Validate-benchmarks Job Only Respects skip-validate-benchmarks#1611

Merged
sam0x17 merged 20 commits intodevnet-readyfrom
validate-benchmarks-only-respects-correct-label
May 8, 2025
Merged

Validate-benchmarks Job Only Respects skip-validate-benchmarks#1611
sam0x17 merged 20 commits intodevnet-readyfrom
validate-benchmarks-only-respects-correct-label

Conversation

@JohnReedV
Copy link
Contributor

@JohnReedV JohnReedV commented May 7, 2025

Description

This PR fixes a bug where the validate-benchmarks job will re-run on any label change.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

@JohnReedV JohnReedV added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway run-bittensor-e2e-tests skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-cargo-audit This PR fails cargo audit but needs to be merged anyway skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed run-bittensor-e2e-tests labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 7, 2025
@JohnReedV JohnReedV added skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway and removed skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway labels May 8, 2025
@JohnReedV JohnReedV added the skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway label May 8, 2025
@JohnReedV JohnReedV removed the skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway label May 8, 2025
@JohnReedV JohnReedV added the skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway label May 8, 2025
@JohnReedV JohnReedV removed the skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway label May 8, 2025
@sam0x17 sam0x17 added the skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway label May 8, 2025
@sam0x17 sam0x17 marked this pull request as ready for review May 8, 2025 19:34
@sam0x17 sam0x17 removed the skip-validate-benchmarks This PR fails validate benchmarks but needs to be merged anyway label May 8, 2025
@sam0x17
Copy link
Contributor

sam0x17 commented May 8, 2025

ok, it works

@sam0x17 sam0x17 merged commit ecd3444 into devnet-ready May 8, 2025
25 checks passed
This was referenced May 8, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

Assignees

No one assigned

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohnReedV @sam0x17