RPC to get validators

[open-junius]

Description

Related Issue(s)

• Closes Get validators efficiently #1589

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

[keithtensor]

This means if the SelectiveMetagraphIndex is Validators, we'd still be going to this match arm. Is this correct?

[open-junius]

Yes, it is correct. get validators is a separate branch. that's the validator_only parameter means.

[keithtensor]

But is there a case where the validators_only parameter is false, and yet the SelectedMetagraphIndex is Validators?

[open-junius]

if validators_only is false, we don't return validators in the result. The index is wield, let me check how to change it. thanks

[open-junius]

removed the validators index.

[camfairchild]

should we not use the index of ValidatorsOnly to do this and not add a boolean to the api?

e.g. remove the only_validators param. Then, if ValidatorsOnly is present just keys that are validators.

This requires we add a uids field to the struct also

[basfroman]

I'd say this impl can be like this:

• we add SelectedMetagraphIndex::Validators. Then it gonna handled the same way as other SelectedMetagraphIndex indices.
• we add validators field into Metagraph struct.

Result:

• get_metagraph_info always has filed Metagraph::validators field
• SelectiveMetagraph returns object with filed validators as Vec with related HK indexes if SelectedMetagraphIndex::Validators passed in params as item in field_indices
• SDK MetagraphInfo class will get a new field validators

This is gonnabe clearest way for this and SDK implementation as far as I see.
Pleas feel free to correct me if I'm wrong.

[open-junius]

Agreed, we can handle the validators the same as other items in metagraph. user can get any data according to passed index list.

[basfroman]

LGTM for SDK
Tested with PR opentensor/bittensor#2887 locally