Add sr25519 precompiled pallet#1702
Merged
sam0x17 merged 3 commits intoopentensor:devnet-readyfrom Jun 11, 2025
Merged
Conversation
93e8fa1 to
4868e3b
Compare
Contributor
Author
|
Fixed and run both |
open-junius
reviewed
Jun 2, 2025
open-junius
reviewed
Jun 2, 2025
Contributor
for clean merge check, please pull the devnet-ready again, and merge to your branch. |
Contributor
Author
|
Fixed above comments and merged devnet-ready to current branch |
open-junius
approved these changes
Jun 11, 2025
sam0x17
approved these changes
Jun 11, 2025
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add sr25519 precompiled pallet so that substrate wallets can sign using sr25519 and verification can be done on EVM. The implementation is exactly the same as ed25519 in terms of abi interface but the main difference between
precompiles/src/sr25519.rsandprecompiles/src/ed25519.rsis the underlying function used to verify the signature.Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.