Skip to content

Add sr25519 precompiled pallet#1702

Merged
sam0x17 merged 3 commits intoopentensor:devnet-readyfrom
tensorplex-labs:features/add-sr25519
Jun 11, 2025
Merged

Add sr25519 precompiled pallet#1702
sam0x17 merged 3 commits intoopentensor:devnet-readyfrom
tensorplex-labs:features/add-sr25519

Conversation

@axionyu
Copy link
Contributor

@axionyu axionyu commented May 30, 2025

Description

Add sr25519 precompiled pallet so that substrate wallets can sign using sr25519 and verification can be done on EVM. The implementation is exactly the same as ed25519 in terms of abi interface but the main difference between precompiles/src/sr25519.rs and precompiles/src/ed25519.rs is the underlying function used to verify the signature.

Related Issue(s)

  • N.A.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@axionyu axionyu force-pushed the features/add-sr25519 branch from 93e8fa1 to 4868e3b Compare June 2, 2025 03:24
@axionyu
Copy link
Contributor Author

axionyu commented Jun 2, 2025

Fixed and run both cargo fmt and cargo clippy. Rebased to keep the commit branch clean.

@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 2, 2025
@open-junius
Copy link
Contributor

Fixed and run both cargo fmt and cargo clippy. Rebased to keep the commit branch clean.

for clean merge check, please pull the devnet-ready again, and merge to your branch.

@axionyu
Copy link
Contributor Author

axionyu commented Jun 2, 2025

Fixed above comments and merged devnet-ready to current branch

@sam0x17 sam0x17 merged commit a667cd2 into opentensor:devnet-ready Jun 11, 2025
80 of 86 checks passed
This was referenced Jun 18, 2025
@sam0x17 sam0x17 mentioned this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants