Add changes from Max and Dr. Nick#1716
Merged
gztensor merged 3 commits intofeat/uniswapv3-lpfrom Jun 4, 2025
Merged
Conversation
liamaharon
reviewed
Jun 4, 2025
pallets/swap/src/pallet/impls.rs
Outdated
Comment on lines
160
to
180
| // println!("\tAction : {:?}", self.action); | ||
| // println!( | ||
| // "\tCurrent Price : {}", | ||
| // self.current_sqrt_price * self.current_sqrt_price | ||
| // ); | ||
| // println!( | ||
| // "\tTarget Price : {}", | ||
| // self.target_sqrt_price * self.target_sqrt_price | ||
| // ); | ||
| // println!( | ||
| // "\tLimit Price : {}", | ||
| // self.limit_sqrt_price * self.limit_sqrt_price | ||
| // ); | ||
| // println!( | ||
| // "\tEdge Price : {}", | ||
| // self.edge_sqrt_price * self.edge_sqrt_price | ||
| // ); | ||
| // println!( | ||
| // "\t{}", | ||
| // format!("Delta In : {}", self.delta_in).yellow() | ||
| // ); |
liamaharon
reviewed
Jun 4, 2025
pallets/swap/src/pallet/impls.rs
Outdated
| // Hold the fees | ||
| Pallet::<T>::add_fees(self.netuid, self.order_type, self.fee); | ||
| let delta_out = Pallet::<T>::convert_deltas(self.netuid, self.order_type, self.delta_in); | ||
| // println!("\t{}", format!("Delta Out : {}", delta_out).green()); |
liamaharon
reviewed
Jun 4, 2025
pallets/swap/src/pallet/impls.rs
Outdated
Comment on lines
426
to
435
| // println!("======== Start Swap ========"); | ||
| // println!("Amount Remaining: {}", amount_remaining); | ||
|
|
||
| // Swap one tick at a time until we reach one of the stop conditions | ||
| while amount_remaining > 0 { | ||
| // println!("\nIteration: {}", iteration_counter); | ||
| // println!( | ||
| // "\tCurrent Liquidity: {}", | ||
| // CurrentLiquidity::<T>::get(netuid) | ||
| // ); |
ales-otf
approved these changes
Jun 4, 2025
ales-otf
approved these changes
Jun 4, 2025
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.