Skip to content

remove subnet enabled check on validate_remove_stake #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam0x17 merged 4 commits into from
Jun 10, 2025
Merged

remove subnet enabled check on validate_remove_stake #1732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
619ef06
remove subnet exists check on validate_remove_stake
sam0x17 Jun 10, 2025
a69315b
whoops, wrong line
sam0x17 Jun 10, 2025
315dedc
fix test
sam0x17 Jun 10, 2025
5f552ae
clippy
sam0x17 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pallets/subtensor/src/staking/stake_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ impl<T: Config> Pallet<T> {
ensure!(Self::if_subnet_exist(netuid), Error::<T>::SubnetNotExists);

// Ensure that the subnet is enabled.
Self::ensure_subtoken_enabled(netuid)?;
// Self::ensure_subtoken_enabled(netuid)?;

// Ensure that the stake amount to be removed is above the minimum in tao equivalent.
if let Some(tao_equivalent) = Self::sim_swap_alpha_for_tao(netuid, alpha_unstaked) {
Expand Down
24 changes: 12 additions & 12 deletions pallets/subtensor/src/tests/subnet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ fn test_subtoken_enable() {
});
}

// cargo test --package pallet-subtensor --lib -- tests::subnet::test_subtoken_enable_reject_trading_before_enable --exact --show-output
// cargo test --package pallet-subtensor --lib --
// tests::subnet::test_subtoken_enable_reject_trading_before_enable --exact --show-output
#[allow(clippy::unwrap_used)]
#[test]
fn test_subtoken_enable_reject_trading_before_enable() {
// ensure_subtoken_enabled
Expand Down Expand Up @@ -340,17 +342,15 @@ fn test_subtoken_enable_reject_trading_before_enable() {
stake_bal
);

assert_noop!(
SubtensorModule::remove_stake_limit(
RuntimeOrigin::signed(coldkey_account_id),
hotkey_account_id,
netuid,
amount,
limit_price,
false
),
Error::<Test>::SubtokenDisabled
);
SubtensorModule::remove_stake_limit(
RuntimeOrigin::signed(coldkey_account_id),
hotkey_account_id,
netuid,
amount,
limit_price,
false,
)
.unwrap();

assert_noop!(
SubtensorModule::remove_stake(
Expand Down
Loading