Skip to content

Make subnet ID's type-safe#1733

Merged
ales-otf merged 13 commits intodevnet-readyfrom
sasha/chore/netuid-type
Jun 11, 2025
Merged

Make subnet ID's type-safe#1733
ales-otf merged 13 commits intodevnet-readyfrom
sasha/chore/netuid-type

Conversation

@ales-otf
Copy link
Contributor

@ales-otf ales-otf commented Jun 10, 2025

Description

Currently we use u16 for subnet ID's throughout the codebase. This is unsafe and error-prone. This PR introduces a wrapper around u16 to make it type-safe and improve code documentation. New type is backward-compatible with existing API's.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): refactoring

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@ales-otf ales-otf added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 10, 2025
@ales-otf ales-otf marked this pull request as ready for review June 11, 2025 13:12
@ales-otf ales-otf merged commit 1100804 into devnet-ready Jun 11, 2025
28 of 29 checks passed
@ales-otf ales-otf deleted the sasha/chore/netuid-type branch June 11, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants