Merged
Conversation
bdmason
reviewed
Jun 17, 2025
bdmason
reviewed
Jun 17, 2025
bdmason
approved these changes
Jun 17, 2025
Contributor
bdmason
left a comment
There was a problem hiding this comment.
Looks good, comments are about superficial things.
Contributor
|
@opentensor/cerebrum / @opentensor/gyrus / @opentensor/cortex breaking change detected! Please prepare accordingly! |
l0r1s
reviewed
Jun 23, 2025
l0r1s
reviewed
Jun 23, 2025
l0r1s
previously approved these changes
Jun 23, 2025
sam0x17
approved these changes
Jun 30, 2025
Merged
|
I think this same-block limitation is also applying to stake that is moved under the same triplet from the origin of spearate hotkeys and towards a validator hotkey for the purposes of staking. I will test with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces staking operation rate limits. All operations that 'add stake' including moving stake operations set a "this block limit". It prevents any 'remove stake' operations including moving stake operations until the next block. The exception is transfer_stake that doesn't set the destination limit. All limits will be removed on each block. We're limiting the triplet (hot, cold, subnet).