Remove stake full limit precompile#1780
Merged
open-junius merged 9 commits intodevnet-readyfrom Jun 26, 2025
Merged
Conversation
open-junius
added
the
skip-cargo-audit
precompiles/src/staking.rs
Outdated
| let call = pallet_subtensor::Call::<R>::remove_stake_full_limit { | ||
| hotkey, | ||
| netuid: netuid.into(), | ||
| limit_price: Some(limit_price), |
Collaborator
There was a problem hiding this comment.
What do you think about introducing a convention for Solidity code here? If limit_price == 0 then None. If you agree it makes sense to update the Solidity method doc section as well.
Contributor
Author
There was a problem hiding this comment.
I can see there is already a method removeStake can do the same as set limit_price as 0. Maybe I mixed up the function. It is fine to convert as you mentioned. But the solidity developer need to know this rule, could cause some loss if they wrongly set it as 0.
open-junius
changed the base branch from
remove_stake_full_limit
to
devnet-ready
open-junius
requested review from
JohnReedV,
ales-otf,
basfroman,
camfairchild,
gztensor,
l0r1s and
sam0x17
shamil-gadelshin
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add precompile and test in evm.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.