Merged
Conversation
open-junius
added
the
skip-cargo-audit
open-junius
requested review from
JohnReedV,
ales-otf,
basfroman,
camfairchild,
gztensor,
l0r1s,
ppolewicz,
sam0x17 and
shamil-gadelshin
and removed request for
camfairchild and
l0r1s
sam0x17
approved these changes
Jul 2, 2025
camfairchild
suggested changes
Jul 2, 2025
Contributor
camfairchild
left a comment
camfairchild
left a comment
There was a problem hiding this comment.
Should not enable registrations forcibly. Especially not pow
camfairchild
reviewed
Jul 3, 2025
| netuid: NetUid, | ||
| registration_allowed: bool, | ||
| ) -> DispatchResult { | ||
| pallet_subtensor::Pallet::<T>::ensure_subnet_owner_or_root(origin, netuid)?; |
camfairchild
reviewed
Jul 3, 2025
Comment on lines
+37
to
+40
| if !Pallet::<T>::get_network_pow_registration_allowed(*netuid) { | ||
| Pallet::<T>::set_network_pow_registration_allowed(*netuid, true); | ||
| weight = weight.saturating_add(T::DbWeight::get().writes(1)); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR will disallow the subnet owner too disable registration. Also migration both registration allowed and pow registration allowed for all subnets, set them as true.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.