Skip to content

Fix / Allow owner to toggle POW registrations #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam0x17 merged 4 commits into from
Jul 3, 2025
Merged

Fix / Allow owner to toggle POW registrations #1815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76a8237
allow owner to toggle POW registrations
JohnReedV Jul 3, 2025
4b54033
remove POW-registration from migration
JohnReedV Jul 3, 2025
32672c2
revert test
JohnReedV Jul 3, 2025
9c805ac
update migration test
JohnReedV Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pallets/admin-utils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ pub mod pallet {
netuid: NetUid,
registration_allowed: bool,
) -> DispatchResult {
ensure_root(origin)?;
pallet_subtensor::Pallet::<T>::ensure_subnet_owner_or_root(origin, netuid)?;

pallet_subtensor::Pallet::<T>::set_network_pow_registration_allowed(
netuid,
Expand Down
15 changes: 0 additions & 15 deletions pallets/admin-utils/src/tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,8 +983,6 @@ fn test_sudo_set_network_pow_registration_allowed() {
let to_be_set: bool = true;
add_network(netuid, 10);

let owner = SubtensorModule::get_subnet_owner(netuid);

let init_value: bool = SubtensorModule::get_network_pow_registration_allowed(netuid);
assert_eq!(
AdminUtils::sudo_set_network_pow_registration_allowed(
Expand All @@ -999,19 +997,6 @@ fn test_sudo_set_network_pow_registration_allowed() {
init_value
);

assert_eq!(
AdminUtils::sudo_set_network_pow_registration_allowed(
<<Test as Config>::RuntimeOrigin>::signed(owner),
netuid,
to_be_set
),
Err(DispatchError::BadOrigin)
);
assert_eq!(
SubtensorModule::get_network_pow_registration_allowed(netuid),
init_value
);

assert_ok!(AdminUtils::sudo_set_network_pow_registration_allowed(
<<Test as Config>::RuntimeOrigin>::root(),
netuid,
Expand Down
5 changes: 0 additions & 5 deletions pallets/subtensor/src/migrations/migrate_set_registration_enable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ pub fn migrate_set_registration_enable<T: Config>() -> Weight {
continue;
}

if !Pallet::<T>::get_network_pow_registration_allowed(*netuid) {
Pallet::<T>::set_network_pow_registration_allowed(*netuid, true);
weight = weight.saturating_add(T::DbWeight::get().writes(1));
}

if !Pallet::<T>::get_network_registration_allowed(*netuid) {
Pallet::<T>::set_network_registration_allowed(*netuid, true);
weight = weight.saturating_add(T::DbWeight::get().writes(1));
Expand Down
4 changes: 2 additions & 2 deletions pallets/subtensor/src/tests/migration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,10 +936,10 @@ fn test_migrate_set_registration_enable() {
Test,
>();

// After migration, registration should be enabled for all subnets except root
// After migration, regular registration should be enabled for all subnets except root
for netuid in netuids.iter() {
assert!(SubtensorModule::get_network_registration_allowed(*netuid));
assert!(SubtensorModule::get_network_pow_registration_allowed(
assert!(!SubtensorModule::get_network_pow_registration_allowed(
*netuid
));
}
Expand Down
Loading