Skip to content

Disable unsupported fast sync mode. #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam0x17 merged 2 commits into from
Jul 11, 2025
Merged

Disable unsupported fast sync mode. #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf4079
Disable unsupported fast sync mode.
shamil-gadelshin Jul 11, 2025
dc5c11b
Bump spec version 292->293
shamil-gadelshin Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions node/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use sc_consensus::{
};
use sc_consensus_grandpa::BlockNumberOps;
use sc_consensus_slots::BackoffAuthoringOnFinalizedHeadLagging;
use sc_network::config::SyncMode;
use sc_network_sync::strategy::warp::{WarpSyncConfig, WarpSyncProvider};
use sc_service::{Configuration, PartialComponents, TaskManager, error::Error as ServiceError};
use sc_telemetry::{Telemetry, TelemetryHandle, TelemetryWorker, log};
Expand Down Expand Up @@ -348,6 +349,15 @@ where
NumberFor<Block>: BlockNumberOps,
NB: sc_network::NetworkBackend<Block, <Block as BlockT>::Hash>,
{
// Substrate doesn't seem to support fast sync option in our configuration.
if matches!(config.network.sync_mode, SyncMode::LightState { .. }) {
log::error!(
"Supported sync modes: full, warp. Provided: {:?}",
config.network.sync_mode
);
return Err(ServiceError::Other("Unsupported sync mode".to_string()));
}

let build_import_queue = if sealing.is_some() {
build_manual_seal_import_queue
} else {
Expand Down
2 changes: 1 addition & 1 deletion runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
// `spec_version`, and `authoring_version` are the same between Wasm and native.
// This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
// the compatible custom types.
spec_version: 292,
spec_version: 293,
impl_version: 1,
apis: RUNTIME_API_VERSIONS,
transaction_version: 1,
Expand Down
Loading