Block-Based Commit-Reveal Weight Masking for Deregistered UIDs#1862
Merged
sam0x17 merged 7 commits intodevnet-readyfrom Jul 17, 2025
Merged
Block-Based Commit-Reveal Weight Masking for Deregistered UIDs#1862sam0x17 merged 7 commits intodevnet-readyfrom
sam0x17 merged 7 commits intodevnet-readyfrom
Conversation
JohnReedV
added
the
skip-cargo-audit
shamil-gadelshin
previously approved these changes
Jul 17, 2025
Collaborator
shamil-gadelshin
left a comment
shamil-gadelshin
left a comment
There was a problem hiding this comment.
Looks good.
I left a couple of suggestions.
| NetUid, | ||
| Twox64Concat, | ||
| u64, // epoch key | ||
| VecDeque<( |
Collaborator
There was a problem hiding this comment.
What do you think about the dedicated struct here? The struct comments could explain the meaning of these fields.
sam0x17
approved these changes
Jul 17, 2025
This was referenced Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit-Block-Based Commit-Reveal Weight Masking for Deregistered UIDs
Weights are masked whenever a validator still has an unrevealed commit whose commit_block predates the target miner’s latest registration block.