Skip to content

remove a strange case#1864

Merged
open-junius merged 3 commits intodevnet-readyfrom
fix-evm-test
Jul 17, 2025
Merged

remove a strange case#1864
open-junius merged 3 commits intodevnet-readyfrom
fix-evm-test

Conversation

@open-junius
Copy link
Contributor

@open-junius open-junius commented Jul 17, 2025

Description

It is a very wield issue. we run the mocha test for all test cases, but it just run this one "Can register network with identity info and logo url". then exit.

Didn't get the root cause now. So the PR remove this case, to make sure all other test cases can be executed in the CI process. The issue also exists in the local env.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this Jul 17, 2025
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jul 17, 2025
@open-junius open-junius merged commit a521e2f into devnet-ready Jul 17, 2025
92 of 93 checks passed
This was referenced Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants