POW Registration allowance/disallowance#189
Conversation
| // --- 3. Ensure the passed network allows registrations. | ||
| ensure!( | ||
| Self::if_subnet_allows_registration(netuid), | ||
| Self::get_network_pow_registration_allowed(netuid), |
There was a problem hiding this comment.
is there some idiomatic reason for this name change?
I thjink the previous one has a good naming, maybe something like.... Self::subnet_allows_registrations(netuid) which could fit with the context and its semantics. What do you think?
There was a problem hiding this comment.
if_subnet_allows_registration was a duplicate of another function which was already implemented.
ifrit98
left a comment
ifrit98
left a comment
There was a problem hiding this comment.
LGTM! Only question is on some failing tests. Assume these panics are from flaky tests or not updated?
Yep, i do need to update these! Good catch |
|
Burn adjustment tests fixed |
ifrit98
left a comment
ifrit98
left a comment
There was a problem hiding this comment.
LGTM!
Only issue is the test_registration_difficulty_adjustment fails.
Fixed! Thank you for catching this. |
4 participants
This PR adds a sudo call which separately manages whether or not POW registration is enabled for a subnet.