Skip to content

Feat/validate reg network#1944

Merged
sam0x17 merged 20 commits intodevnet-readyfrom
feat/validate-reg-network
Sep 9, 2025
Merged

Feat/validate reg network#1944
sam0x17 merged 20 commits intodevnet-readyfrom
feat/validate-reg-network

Conversation

@camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Aug 13, 2025

Description

Adds tx-validation to the register_network call to prevent spam.

  • checks if the last registration- rate-limit has passed

Also makes it pays::yes in-case the tx slips through some other way.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

@opentensor/cortex -- need to add fee estimate to btcli for this
@opentensor/gyrus

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Aug 13, 2025
sam0x17
sam0x17 previously approved these changes Aug 13, 2025
@sam0x17
Copy link
Contributor

sam0x17 commented Aug 16, 2025

A lot of e2e's need updating with this change

@sam0x17
Copy link
Contributor

sam0x17 commented Aug 22, 2025

conflicts

sam0x17
sam0x17 previously approved these changes Sep 9, 2025
@sam0x17
Copy link
Contributor

sam0x17 commented Sep 9, 2025

some e2e failures

sam0x17
sam0x17 previously approved these changes Sep 9, 2025
@sam0x17 sam0x17 merged commit 7c36b3f into devnet-ready Sep 9, 2025
24 of 25 checks passed
@sam0x17 sam0x17 mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants