Ignore zero alpha stake in clear_small_nomination_if_required#1951
Merged
open-junius merged 1 commit intoopentensor:devnet-readyfrom Aug 28, 2025
Merged
Conversation
Contributor
|
need to rebase to fix the failed unit testcase. |
edfb17b to
0aa0cb0
Compare
Contributor
Author
|
@open-junius Did the rebase and ran the tests again locally. Everything seems to be working, not sure what's the issue with the CI |
Contributor
|
No worry. I just need to approve the CI process again. Let's see the result this time. |
Contributor
Author
|
@open-junius Any idea what might be the root issue here? |
Contributor
It is my bad, changed a parameter before. cause some e2e test failed. should be fixed soon. |
open-junius
approved these changes
Aug 28, 2025
ales-otf
approved these changes
Aug 28, 2025
9ca9888
into
opentensor:devnet-ready
153 of 160 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
clear_small_nomination_if_requirednow validates thatalpha_stake > 0before it proceeds to clear the small nomination. This fixes the issue where the function would emit unnecessaryStakeRemovedandDepositevents with zero values.Related Issue(s)
clear_small_nomination_if_requiredemits events even if the balance wasn't changed #1950Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.