Feat/mvds00 run coinbase refactoring#1980
Merged
sam0x17 merged 5 commits intoopentensor:devnet-readyfrom Aug 28, 2025
Merged
Conversation
gztensor
requested changes
Aug 27, 2025
Contributor
gztensor
left a comment
There was a problem hiding this comment.
Not sure about moving this code to the different function:
if BlockEmission::<T>::get() != block_emission_u64 {
BlockEmission::<T>::put(block_emission_u64);
}
Otherwise looks good.
1371ae3 to
24a1334
Compare
gztensor
previously approved these changes
Aug 28, 2025
sam0x17
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Various minor tweaks to improve readability and performance of code. Fixes an issue where BlockEmission would be repeatedly set with wrong values.
Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyAdditional Notes
This is the first of a possible sequence of small PRs to refactor some subtensor code. This was discussed at OpenDev and in the new
#refactor-run_coinbasediscord channel.