Cleanup math and LastUpdate fix#2069
Merged
sam0x17 merged 11 commits intodevnet-readyfrom Sep 19, 2025
Merged
Conversation
…x get_last_update.
sam0x17
previously approved these changes
Sep 19, 2025
Collaborator
shamil-gadelshin
left a comment
There was a problem hiding this comment.
I noticed that you have two policies for replacing assert_eq!(len1, len2) - safe implementation and skipping. Is it intentional?
Another question - do we have all this math covered by tests?
shamil-gadelshin
previously approved these changes
Sep 19, 2025
l0r1s
reviewed
Sep 19, 2025
l0r1s
previously approved these changes
Sep 19, 2025
8b3d120
l0r1s
approved these changes
Sep 19, 2025
sam0x17
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LastUpdatevector update inadd_neuronType of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly