Skip to content

always include the netuid in selective metagraph#2097

Merged
open-junius merged 7 commits intodevnet-readyfrom
always-include-netuid
Oct 2, 2025
Merged

always include the netuid in selective metagraph#2097
open-junius merged 7 commits intodevnet-readyfrom
always-include-netuid

Conversation

@open-junius
Copy link
Contributor

Description

should put the netuid into the result of selective metagraph, instead of returning the default value 0.
no matter the index is selected or not.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this Oct 2, 2025
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Oct 2, 2025
None
} else {
let mut result = SelectiveMetagraph::default();
let netuid_index =
Copy link
Contributor

@gztensor gztensor Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename netuid_index to something else to avoid confusion with NetUidStorageIndex

@open-junius open-junius merged commit 3146dbb into devnet-ready Oct 2, 2025
56 checks passed
@sam0x17 sam0x17 mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants