Merged
Conversation
l0r1s
reviewed
Oct 23, 2025
Comment on lines
366
to
368
| pub fn DefaultDelegateTake<T: Config>() -> u16 { | ||
| T::InitialDefaultDelegateTake::get() | ||
| } |
Collaborator
There was a problem hiding this comment.
This file needs a cleanup because this makes no sense to wrap the #[pallet::constant] into a type value, we can just use it like that, type_value derives a Get<T> implementation that is already existing for InitialDefaultDelegateTake
Also, a lot of these type values are not used anywhere
edit: I added this to the #2047 issue
Contributor
Author
There was a problem hiding this comment.
I assigned the #2047 to me. Let's merge the PR at first, then we have correct doc for rust doc and type script. I will create a new PR for 2047.
l0r1s
previously approved these changes
Oct 23, 2025
sam0x17
previously approved these changes
Oct 29, 2025
2c8be10 to
34cae8e
Compare
Contributor
|
merge conflict @juniuszhou |
shamil-gadelshin
previously approved these changes
Nov 6, 2025
l0r1s
previously approved these changes
Nov 6, 2025
c32c955
sam0x17
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pr improves the doc for storage definition in subtensor pallet.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.