Skip to content

set root owner for fast time#2153

Merged
sam0x17 merged 4 commits intodevnet-readyfrom
set-root-owner-fast-runtime
Oct 28, 2025
Merged

set root owner for fast time#2153
sam0x17 merged 4 commits intodevnet-readyfrom
set-root-owner-fast-runtime

Conversation

@open-junius
Copy link
Contributor

Description

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this Oct 24, 2025
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Oct 24, 2025
l0r1s
l0r1s previously approved these changes Oct 24, 2025
@basfroman
Copy link
Collaborator

basfroman commented Oct 24, 2025

Hey @open-junius this generally works for us. The test fix is ​​one line. Thanks!
But there's something odd: the SN0 owner's coldkey is currently an Alice CK, but the owner's hotkey is still from Genesis one.
Can SN0 owner HK be updated too?

@open-junius
Copy link
Contributor Author

open-junius commented Oct 27, 2025

Hey @open-junius this generally works for us. The test fix is ​​one line. Thanks! But there's something odd: the SN0 owner's coldkey is currently an Alice CK, but the owner's hotkey is still from Genesis one. Can SN0 owner HK be updated too?

Yes, I can also add a key as hotkey stored in SubnetOwnerHotkey. Which account should I set for SN0, Bob or someone else? @basfroman

@basfroman
Copy link
Collaborator

Hey @open-junius this generally works for us. The test fix is ​​one line. Thanks! But there's something odd: the SN0 owner's coldkey is currently an Alice CK, but the owner's hotkey is still from Genesis one. Can SN0 owner HK be updated too?

Yes, I can also add a key as hotkey stored in SubnetOwnerHotkey. Which account should I set for SN0, Bob or someone else? @basfroman

Historically, we've had a strange situation with wallets in tests. All wallets like Alice, Bob, and so on have identical hot and coldkeys. I want to change this. I think now is the best time.
If you don't mind, let's set up the following for the subnet owner:

  • coldkey - as you've already implemented in this PR (from Alice)
  • hotkey - Pair::from_string(&"//Alice_hk", None)

after that we can create Alice HK keypair simply with

Wallet.create_from_uri("//Alice_hk")

Thank you!

@basfroman
Copy link
Collaborator

@sam0x17 pls merge it
Also, fix for metagraph test is ready after you merge this pr.

@sam0x17 sam0x17 merged commit b710d30 into devnet-ready Oct 28, 2025
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants