Hotfix/vune/subnet-dereg-burn-use-issuance#2190
Hotfix/vune/subnet-dereg-burn-use-issuance#2190camfairchild merged 5 commits intohotfix/vune/epoch-fn-inpfrom
Conversation
* impl tests benchmarks * bump spec * remove duplicate remove * use alpha out here * Hotfix/vune/epoch sub fix (#2186) * fix: injection logic * fix: fmt' * emit full alpha if subsidized * fix coinbase test * fix tests * Revert "Hotfix/vune/epoch sub fix (#2186)" This reverts commit ccc6bba. * add total issuance bump * no alpha out thing * add tests for emissions w/ subs * bump spec * Fix clippy warnings * Hotfix/vune/epoch sub fix (#2186) * fix: injection logic * fix: fmt' * rename drain_pending to distr em * remove arg and total internally * test pending em * make sure we check subsidize during those tests * fix root claim tests * helper and clippy * bump spec * rename subsidy to root flag * only pull these values if root selling * rename subsidy checks to the root_sell flag * rename subsidy to excess_tao * use recycle alpha helper * Hotfix/vune/subnet-dereg-burn-use-issuance (#2190) * use alpha issuance for owner estimate * fix tests * use price for estimate only * fix tests for using just price * docs: comment fix * remove log out --------- Co-authored-by: 0xcacti <97139981+0xcacti@users.noreply.github.com> Co-authored-by: Shamil Gadelshin <shamilgadelshin@gmail.com>
|
I request that all PRs have actual descriptions of the issue and the resolution. They do not have to be verbose, but PRs are not transparent to the community readily without reading code. It also helps non-approvers who are reviewing to know if it actually meets the need or raises concerns. It also provides history of the mindset of the product. The PR template is mostly ignored atm. Approvers should require this, imo. |
I agree with this. The problem is that the announcement says that there are more details to be had here. There are no details to be had here unless you can read the code. If you are a non-coder who might be asked "what did this change do", having even just a basic explanation of what it does would be useful. Thank you in advance. : ) |
5 participants
Description
Uses the Alpha issuance to estimate the amount of owner emissions.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.