fix: remove duplicate safe_exp function, use exp_safe instead

[MkDev11]

Summary

Resolves #2149

Problem

The codebase has two similar exponentiation functions in math.rs:

1. exp_safe (line 172): Robust implementation with:

   • Input clamping to [-20, 20] range
   • Smart error handling (returns max_value for positive overflow, 0 for negative)
   • Existing test coverage in tests/math.rs

2. safe_exp (line 1597): Simple wrapper that:

   • Has no input clamping
   • Always returns 0 on any error

Solution

• Remove the duplicate safe_exp function from math.rs
• Update run_epoch.rs to use exp_safe instead

Why exp_safe is better

1. Clamps input to prevent overflow in the first place
2. Returns max_value (not 0) when large positive inputs would overflow - more mathematically correct
3. Has existing test coverage

Testing

• cargo check -p pallet-subtensor passes
• Existing exp_safe tests in tests/math.rs provide coverage

Contribution by Gittensor, learn more at https://gittensor.io/

[MkDev11]

@gztensor @sam0x17 Hope you had great weekends. Can you please check the PR and let me know the results?

[gztensor]

@MkDev11 , thank you for your contribution. While the functions are not exactly the same, the argument range of exp_safe in alpha_sigmoid is from -5.0 to +5.0, so the safe_exp -20..+20 range fits the (only) use case. Approving.

[MkDev11]

@sam0x17 Please check the PR when you are available.

[sam0x17]

CI failing

The base branch was changed.

[MkDev11]

@sam0x17 Can you check again?

[MkDev11]

@gztensor Can you approve the PR again? I changed the base branch from main to devnet-ready