Skip to content

Allow decreasing delegate take#288

Closed
unconst wants to merge 8 commits intodevelopmentfrom
decrease_take
Closed

Allow decreasing delegate take#288
unconst wants to merge 8 commits intodevelopmentfrom
decrease_take

Conversation

@unconst
Copy link
Contributor

@unconst unconst commented Mar 27, 2024

Allows delegates the ability to decrease take on their delegates from 18 -> 0 % but only lower.

unconst and others added 3 commits March 27, 2024 11:04
Co-authored-by: cuteolaf <OliverLim818@gmail.com>
Co-authored-by: cuteolaf <OliverLim818@gmail.com>
Co-authored-by: cuteolaf <OliverLim818@gmail.com>
Comment on lines +112 to +113
// * 'TxRateLimitExceeded':
// - Thrown if key has hit transaction rate limit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// * 'TxRateLimitExceeded':
// - Thrown if key has hit transaction rate limit
// * 'InvalidTransaction':
// - The delegate is setting a take which is not lower than the previous.

@unconst unconst changed the base branch from main to staging March 27, 2024 17:02
@unconst unconst changed the base branch from staging to development March 27, 2024 17:04
sam0x17 and others added 4 commits April 8, 2024 12:21
Co-authored-by: cuteolaf <OliverLim818@gmail.com>
Co-authored-by: cuteolaf <OliverLim818@gmail.com>
Co-authored-by: cuteolaf <OliverLim818@gmail.com>
Co-authored-by: cuteolaf <OliverLim818@gmail.com>
@distributedstatemachine
Copy link
Collaborator

Closing re: #313 (comment) . A new PR will be opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants