Skip to content

[docs] Fix the lite/archive node on test chain command#324

Closed
birkskyum wants to merge 2 commits intoopentensor:developmentfrom
birkskyum:fix-docs-test-node
Closed

[docs] Fix the lite/archive node on test chain command#324
birkskyum wants to merge 2 commits intoopentensor:developmentfrom
birkskyum:fix-docs-test-node

Conversation

@birkskyum
Copy link

@birkskyum birkskyum commented Apr 13, 2024

The command altered here introduced an issue:

https://github.com/opentensor/subtensor/pull/321/files#diff-e5df68e2ba1b76797b26a032c414ae59477b34689851e95cfc3b434e67e7c5caL193-L202

It's necessary to also update --ws-max-connections -> --rpc-max-connections and to remove the trailing --ws-external which doesn't exist anymore

I also updated the test bootnode, so it aligns with the correct peer ID, similar to the change in:
553d772

Otherwise, users will see terminal outputs like:

 💔 The bootnode you want to connect to at /dns/bootnode.test.finney.opentensor.ai/tcp/30333/p2p/12D3KooWDe7g2JbNETiKypcKT1KsCEZJbTzEHCn8hpd4PHZ6pdz5 provided a different peer ID 12D3KooWPM4mLcKJGtyVtkggqdG84zWrd7Rij6PGQDoijh1X86Vr than the one you expect 12D3KooWDe7g2JbNETiKypcKT1KsCEZJbTzEHCn8hpd4PHZ6pdz5

@birkskyum birkskyum changed the title Fix the lite/archive node on test chain command [docs] Fix the lite/archive node on test chain command Apr 13, 2024
@sam0x17 sam0x17 assigned JohnReedV and unassigned JohnReedV Apr 15, 2024
@sam0x17 sam0x17 requested a review from JohnReedV April 15, 2024 04:12

```bash title="With bootnodes set to testnet and --sync=warp setting, for lite node."
./target/release/node-subtensor --chain raw_spec.json --base-path /tmp/blockchain --sync=warp --execution wasm --wasm-execution compiled --port 30333 --max-runtime-instances 64 --rpc-max-response-size 2048 --rpc-cors all --rpc-port 9944 --bootnodes /dns/bootnode.test.finney.opentensor.ai/tcp/30333/p2p/12D3KooWDe7g2JbNETiKypcKT1KsCEZJbTzEHCn8hpd4PHZ6pdz5 --ws-max-connections 16000 --no-mdns --in-peers 8000 --out-peers 8000 --prometheus-external --rpc-external --ws-external
./target/release/node-subtensor --chain raw_spec.json --base-path /tmp/blockchain --sync=warp --execution wasm --wasm-execution compiled --port 30333 --max-runtime-instances 64 --rpc-max-response-size 2048 --rpc-cors all --rpc-port 9944 --bootnodes /dns/bootnode.test.finney.opentensor.ai/tcp/30333/p2p/12D3KooWPM4mLcKJGtyVtkggqdG84zWrd7Rij6PGQDoijh1X86Vr --rpc-max-connections 16000 --no-mdns --in-peers 8000 --out-peers 8000 --prometheus-external --rpc-external
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary prints the following warning when run with these parameters:

CLI parameter `--execution` has no effect anymore and will be removed in the future

I think Parity made execution to be wasm-only, so this parameter doesn't make any difference.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you get any error when running with -e binary before these changes like i do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants