Fix migration order, comment on_runtime_upgrade#372
Merged
distributedstatemachine merged 1 commit intodevelopmentfrom Apr 30, 2024
Merged
Fix migration order, comment on_runtime_upgrade#372distributedstatemachine merged 1 commit intodevelopmentfrom
distributedstatemachine merged 1 commit intodevelopmentfrom
Conversation
sam0x17
approved these changes
Apr 29, 2024
distributedstatemachine
approved these changes
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is primarily a fix for migration order.
migrate_delete_subnet_21andmigrate_delete_subnet_3update to respectively storage versions of 4 and 5, but themigrate_delete_subnet_3migration is called first inon_runtime_upgrade, somigrate_delete_subnet_21will never run.Related Issue(s)
n/a
Type of Change
Breaking Change
n/a
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
n/a
Additional Notes
n/a