Skip to content

fix: reject registrations only after 3 times target#377

Merged
shibshib merged 306 commits intoopentensor:mainfrom
camfairchild:fix/fix-reg-rejection-limit
Apr 29, 2024
Merged

fix: reject registrations only after 3 times target#377
shibshib merged 306 commits intoopentensor:mainfrom
camfairchild:fix/fix-reg-rejection-limit

Conversation

@camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Apr 29, 2024

Description

Hot fix of the registration rejection limit

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

sam0x17 and others added 30 commits March 12, 2024 17:56
@sam0x17
fix subtensor pallet test mock config
352b25f
@sam0x17
fix admin-utils mock test config
b9824bf
@sam0x17
try to fix construct_runtime!
33d4b74
@sam0x17
try to fix collective construct_runtime!
8992430
@sam0x17
fix collective pallet test config
cb0da7c
@sam0x17
fix missing BuildStorage import
00ebd86
@sam0x17
fix several new_test_ext()s
37a5b36
@sam0x17
apply auto formatting to all files
a567211
@sam0x17
Merge remote-tracking branch 'origin/sam-cargo-fmt' into sam-upgrade-…
fd585c3 
…polkadot-1.0
@sam0x17
more fixes
053726b
@sam0x17
fix commitments pallet test construct_runtime!
83bc3f6
@sam0x17
fix admin-utils mock runtime and pallet_balances config
fd42f35
@sam0x17
fix subtensor mock/test construct_runtime and config
1345aee
@sam0x17
remove deprecated Where section
b223b86
@sam0x17
fix compile error 🎉 🎉 🎉 🎉 🎉
49c2bfc
@sam0x17
Merge remote-tracking branch 'origin/main' into sam-upgrade-polkadot-1.0
1f82090
@keithtensor
Add clippy to CI
4a57e9a
@keithtensor
Perform cargo fmt check on all targets and features
506b524
@keithtensor
Fix some clippy warnings
79044e8
@keithtensor
Fix compilation errors
6417b47
@sam0x17
Merge pull request #266 from opentensor/keith-add-clippy-ci
65af4e3 
Add clippy check to CI
@keithtensor
Fix CI
2f3aa14
@keithtensor
Install rustfmt and clippy on CI
e789084
@keithtensor
Disable checking of all targets and features
4e626ba
@keithtensor
Install the right nightly
667b4a5
@keithtensor
Make sure we're using the right year of the nightly
6e23b3f
@keithtensor
Remove try-runtime subcommand
1b2b526
@sam0x17
fix existential deposit issue
e8c6a91
fix: clippy
e5e2235
@sam0x17
sam revamp CI
86ef251
open-junius and others added 23 commits April 25, 2024 12:51
@open-junius
update function name
bd99247
@open-junius
Merge pull request #358 from opentensor/fix-wrong-comments
d44ea6e 
Correct a comment and an error
@sam0x17
Merge pull request #362 from opentensor/fix-issuance-test-warning
487054c
@orriin
chore: clippy and rustc 1.77.2
036ad91 
chore: large enum

chore: update toolchain

,

fix step
@orriin
merge
f6294eb
@orriin
remove u64_to_balance
4c63615
@orriin
fix: more clippy warnings
20c51d0
@orriin
fix: more clippy warnings
70ba6d9
@orriin
Merge branch 'chore/clippy' of github.com:opentensor/subtensor into c…
3b9dee8 
…hore/clippy
@orriin
fix: more clippy warnings
96144e9
@orriin
fix: more clippy warnings
3aa9975
@orriin
Merge branch 'chore/clippy' of github.com:opentensor/subtensor into c…
53284cf 
…hore/clippy
@orriin
fix: more clippy lints
fffd2ed
@orriin
ci: add clippy check
2489a6f
@orriin
Update pallets/subtensor/src/registration.rs
115ebe3
@orriin
fix: remove redundant comment
e8f6f6d
@orriin
Merge branch 'chore/clippy' of github.com:opentensor/subtensor into c…
5800530 
…hore/clippy
@orriin
fix: fmt
93de2c5
@orriin
fix: fmt
904662c
@orriin
ci: remove redundant job
c933675
@orriin
Merge pull request #371 from opentensor/chore/clippy
0288a73 
chore: clippy
@sam0x17
Merge remote-tracking branch 'origin/main' into development
fe5c89f
@camfairchild
fix: reject registrations only after 3 times target
cd08289
@JohnReedV JohnReedV self-requested a review April 29, 2024 21:21
JohnReedV
JohnReedV approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@JohnReedV JohnReedV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shibshib shibshib changed the base branch from development to main April 29, 2024 21:34
@shibshib shibshib merged commit a164a80 into opentensor:main Apr 29, 2024
@distributedstatemachine distributedstatemachine mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shibshib shibshib shibshib approved these changes

@JohnReedV JohnReedV JohnReedV approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.