Skip to content

fix: fix slow proxy test#386

Merged
open-junius merged 1 commit intodevelopmentfrom
fix/fix-slow-proxy-test
May 1, 2024
Merged

fix: fix slow proxy test#386
open-junius merged 1 commit intodevelopmentfrom
fix/fix-slow-proxy-test

Conversation

@camfairchild
Copy link
Contributor

Description

One of the calls ran during a proxy-pallet test had a long run time (>60s) due to the work hash search.
This PR lowers the difficulty of the test environment to make the runtime much shorter (<0.05s).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): Test fix

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.
Before:
Screenshot 2024-04-30 at 8 56 52 PM
After:
Screenshot 2024-04-30 at 8 57 33 PM

@camfairchild camfairchild requested a review from open-junius May 1, 2024 00:58
@open-junius
Copy link
Contributor

Thank you! there is difficult computing in the register network call. It can help to reduce the execution time

@open-junius open-junius merged commit a322703 into development May 1, 2024
@camfairchild camfairchild deleted the fix/fix-slow-proxy-test branch May 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants