Skip to content

Change minimum take to 18%#399

Merged
sam0x17 merged 1 commit intotestnetfrom
feat/set-narrow-take-limit-bounds
May 7, 2024
Merged

Change minimum take to 18%#399
sam0x17 merged 1 commit intotestnetfrom
feat/set-narrow-take-limit-bounds

Conversation

@gztensor
Copy link
Contributor

@gztensor gztensor commented May 6, 2024

Description

Minimum take is 18% now so that setting take is disabled until admin sets a different minimum take value.

Related Issue(s)

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): Updating a runtime parameter

Breaking Change

n/a

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

n/a

Additional Notes

n/a

@sam0x17 sam0x17 merged commit 9682e70 into testnet May 7, 2024
@sam0x17
Copy link
Contributor

sam0x17 commented May 7, 2024

@gztensor can you now also open a PR doing the exact same change into development just so we come full circle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants