Skip to content

[fix] Revert axon info field ordering#512

Merged
distributedstatemachine merged 2 commits intotestnetfrom
fix/swap-back-fields
Jun 5, 2024
Merged

[fix] Revert axon info field ordering#512
distributedstatemachine merged 2 commits intotestnetfrom
fix/swap-back-fields

Conversation

@camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Jun 5, 2024

Description

The ordering of the AxonInfo struct fields ip and port was swapped erroneously, causing a metadata mismatch with the client-code.

Note: this change only affects testnet. Devent appears not to have the errant change included

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

NA

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@distributedstatemachine distributedstatemachine merged commit 1ad28e4 into testnet Jun 5, 2024
@distributedstatemachine distributedstatemachine deleted the fix/swap-back-fields branch June 5, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants