Closed
Conversation
keithtensor
force-pushed
the
end-recursion
branch
from
24361e0 to
fa55e84
Compare
keithtensor
force-pushed
the
end-recursion
branch
from
fa55e84 to
b51883c
Compare
keithtensor
force-pushed
the
end-recursion
branch
from
b51883c to
812f8bf
Compare
gztensor
approved these changes
Jul 9, 2024
Contributor
gztensor
left a comment
gztensor
left a comment
There was a problem hiding this comment.
Existing unit tests cause a lot of recursion on both branches of if statement in the older version. I am confident this fix doesn't break it.
JohnReedV
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devnet companion: #628
This PR removes the recursive algorithm in
weighted_medianand replaces it with a iterative one.