Skip to content

Resuming the network#631

Merged
distributedstatemachine merged 9 commits intomainfrom
feat/remove_schedule_coldkey_swap
Jul 12, 2024
Merged

Resuming the network#631
distributedstatemachine merged 9 commits intomainfrom
feat/remove_schedule_coldkey_swap

Conversation

@distributedstatemachine
Copy link
Collaborator

@distributedstatemachine distributedstatemachine commented Jul 12, 2024

Description

This PR

  • Removes the schedule cold key swap extrisinc
  • Add swap costs to hotkey/ coldkey swaps
  • swaps Senate members for hotkey swap

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): Network resumption

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@ppolewicz
Copy link
Collaborator

Contrary to description this PR does not seem to remove the schedule cold key swap extrisinc

@distributedstatemachine
Copy link
Collaborator Author

distributedstatemachine commented Jul 12, 2024

Contrary to description this PR does not seem to remove the schedule cold key swap extrisinc

@ppolewicz we kept it under a test cfg gate , otherwise removing it would have broken all our tests : https://github.com/opentensor/subtensor/pull/631/files#diff-9d85ff26db441ec381d86188b389b226449eee4e9847bf0ce3301c0bb6cf93a0R2107.

I have tested it locally, and this extrinsic no longer appears in the runtime

We will remove excise it completely at a later date

@distributedstatemachine distributedstatemachine merged commit 884a179 into main Jul 12, 2024
@ppolewicz
Copy link
Collaborator

@distributedstatemachine maybe rather than delete it we might keep it in the source code under that cfg flag in case a major validator or subnet coldkey ever gets compromised again?

@camfairchild camfairchild deleted the feat/remove_schedule_coldkey_swap branch July 18, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants