Skip to content

Update README.md#657

Merged
unconst merged 2 commits intomainfrom
rajkaramchedu-patch-1-1
Jul 23, 2024
Merged

Update README.md#657
unconst merged 2 commits intomainfrom
rajkaramchedu-patch-1-1

Conversation

@rajkaramchedu
Copy link

Description

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@rajkaramchedu
Copy link
Author

Sorry for multiple PRs here. I thought it would add to my first PR, but Github has its own mind. It created a new PR :- (

@rajkaramchedu
Copy link
Author

Two questions:
(1) Who merges this PR? I, or one of you?
(2) One test is failing. We know it is not needed for docs-only PRs, so what's our next move here? Same applies for this docs-only-PR also: #656

@sam0x17
Copy link
Contributor

sam0x17 commented Jul 23, 2024

Two questions: (1) Who merges this PR? I, or one of you? (2) One test is failing. We know it is not needed for docs-only PRs, so what's our next move here? Same applies for this docs-only-PR also: #656

If you bump the spec version that test will pass but your PR does not need to do that, but that would be one way to get this green since later PRs will need to bump it anyway should be OK to do. If you have two approves and all green CI feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants