Merged
Conversation
orriin
added
the
hotfix
Contributor
|
yeah note that the Finney Deploy Check runs on this PR, so someone bypassed it |
Contributor
These checks are already in place, only way this could have happened is someone using administrator privileges to bypass ;) |
sam0x17
approved these changes
Aug 5, 2024
sam0x17
approved these changes
Aug 5, 2024
sam0x17
approved these changes
Aug 5, 2024
distributedstatemachine
approved these changes
Aug 5, 2024
|
damn legends, thanks for fixing this |
unconst
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #655
A node will attempt to use its native runtime in substitute for the on-chain Wasm runtime if all of spec_name, spec_version, and authoring_version are the same between the Wasm and native binaries. This was causing nodes compiled from
mainto use a runtime slightly different compared to what is on-chain, and write invalid stuff to storage.In the future, CI should prevent us from ever pushing to
maina spec version that matches what is on-chain (cc @sam0x17)See https://docs.substrate.io/maintain/runtime-upgrades/ for more.