Merged
Conversation
open-junius
approved these changes
Aug 8, 2024
Contributor
Author
|
Needs spec bump |
distributedstatemachine
approved these changes
Aug 16, 2024
unconst
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new proxy types:
TransferandSmallTransfer.The
Transferproxy allows onlyBalances::transfer_*extrinsics including keep alive, allow death, and transfer all.The
SmallTransferproxy only allows transfers for amounts belowSMALL_TRANSFER_LIMITwhich is set to0.5 TAOThese new proxy types help to make key management more flexible. By allowing more proxy types such as these one can separate the responsibility of different keys instead of using the parent key, potentially exposing all operations.
An example setup is to have key A use the existing staking proxy type and key B use the transfer type. And then if A becomes compromised an attacker may only stake/unstake. If B becomes compromised, an attacker may only transfer free-balance (i.e. excluding any stake). Thereby reducing the attack surface, while allowing keys to be used in otherwise "hot" deployments.
Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyAdditional Notes
Please provide any additional information or context that may be helpful for reviewers.