custom linting framework + freeze struct enforcement lint#724
Merged
unconst merged 57 commits intodevnet-readyfrom Aug 16, 2024
Merged
custom linting framework + freeze struct enforcement lint#724unconst merged 57 commits intodevnet-readyfrom
unconst merged 57 commits intodevnet-readyfrom
Conversation
sam0x17
requested review from
a team,
JohnReedV,
distributedstatemachine,
keithtensor,
open-junius and
orriin
4 tasks
4 tasks
sam0x17
changed the title
Contributor
Author
|
whoops |
distributedstatemachine
requested changes
Aug 16, 2024
distributedstatemachine
approved these changes
Aug 16, 2024
unconst
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom linting framework + custom lint that forces us to add
#[freeze_struct]to ALL structs in the workspace that haveEncodeand/orDecode. Re-adds#[freeze_struct]to a number of structs that were missing it including 4-5 that previously had it but it got removedFixes #606