Skip to content

Fix rate limit for setting children#733

Merged
distributedstatemachine merged 2 commits intofeat/childkey_takefrom
fix/childkey-rate-limits
Aug 16, 2024
Merged

Fix rate limit for setting children#733
distributedstatemachine merged 2 commits intofeat/childkey_takefrom
fix/childkey-rate-limits

Conversation

@gztensor
Copy link
Contributor

Description

Add rate limiting to set_childkeys extrinsic that uses passes_rate_limit_globally. Make it specific to subnet.

Matching e2e JS tests:
https://github.com/gztensor/subtensor-js-tests/blob/main/src/childkey.test.js

Related Issue(s)

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

n/a

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

n/a

Additional Notes

n/a

@distributedstatemachine distributedstatemachine merged commit cb35762 into feat/childkey_take Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants