Skip to content

Subnet Identities#736

Merged
unconst merged 14 commits intodevnet-readyfrom
subnet-identities
Aug 23, 2024
Merged

Subnet Identities#736
unconst merged 14 commits intodevnet-readyfrom
subnet-identities

Conversation

@JohnReedV
Copy link
Contributor

@JohnReedV JohnReedV commented Aug 14, 2024

Description

Adds subnet Identities

Done:

  • Define subnet identity structs and storage items.
  • Add extrinsic set_subnet_identity.
  • Add the subnet identity fields to SubnetInfo.
  • Remove the identity when the subnet is dissolved.
  • Write unit tests
  • Integrate identities into subnet registration process

Todo:

  • Test Manually

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

  • The extrinsic user_add_network now takes a second parameter identity: Option<SubnetIdentityOf>
  • SubnetInfo has a new parameter identity: Option<SubnetIdentity>.

@JohnReedV JohnReedV marked this pull request as ready for review August 14, 2024 22:11
@JohnReedV JohnReedV requested a review from unconst as a code owner August 14, 2024 22:11
unconst
unconst previously approved these changes Aug 23, 2024
@unconst unconst dismissed stale reviews from distributedstatemachine and themself via 2c2a15d August 23, 2024 16:01
@unconst unconst merged commit 8c17cfd into devnet-ready Aug 23, 2024
@JohnReedV JohnReedV mentioned this pull request Aug 23, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants