Merged
Conversation
open-junius
reviewed
Aug 26, 2024
open-junius
reviewed
Aug 26, 2024
orriin
reviewed
Aug 26, 2024
Comment on lines
+49
to
+52
| #[method(name = "subnetInfo_getSubnetInfo_v2")] | ||
| fn get_subnet_info_v2(&self, netuid: u16, at: Option<BlockHash>) -> RpcResult<Vec<u8>>; | ||
| #[method(name = "subnetInfo_getSubnetsInf_v2")] | ||
| fn get_subnets_info_v2(&self, at: Option<BlockHash>) -> RpcResult<Vec<u8>>; |
Contributor
There was a problem hiding this comment.
Why do all our custom rpc return bytes? It makes them annoying to consume, and returning a SCALE encoded type is no less efficient.
Collaborator
Author
There was a problem hiding this comment.
what would you rather they returned ?
Contributor
There was a problem hiding this comment.
yeah 100% agree on this, opens us up to all sorts of potential footguns and even vulnerabilities potentially on the input side if certain criteria are met
Contributor
There was a problem hiding this comment.
what would you rather they returned ?
The actual shape of the data. SubnetInfov2/Vec<SubnetInfov2>/Result<Vec<Option<SubnetInfov2>>>, or whatever it is before you call .encode
unconst
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR :
SubnetInfov2struct and related RPC methods.user_add_network_with_identitiesstruct to preserve backwards compatibility with cliRelated Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.