Fix pallet indicies and specify them explicitly#764
Merged
unconst merged 2 commits intodevnet-readyfrom Aug 28, 2024
Merged
Conversation
orriin
added
the
no-spec-version-bump
unconst
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduler had been moved from after
Preimageto afterSafeMode.This inadvertently shifted the pallet indicies of
by one, causing a breakage in HoldReasons, which refer to the pallet index the hold is associated with.
This PR moves
Schedulerback afterPreimage, and also specifies explicit pallet indicies to disable this footgun.