forbid as_u* method calls in linting#846
Merged
unconst merged 3 commits intoopentensor:devnet-readyfrom Oct 11, 2024
Merged
Conversation
sam0x17
reviewed
Oct 8, 2024
Contributor
|
ok this looks great, if you could please instead make a PR into unfortunately github doesn't allow specifying a default branch for PRs that is different from default branch for clones edit: I went ahead and changed base but there are now merge conflicts you will need to fix so might be preferable to just reset and stage your changes on top of current |
fd04f99 to
59ba20b
Compare
Contributor
Author
|
lmk if you need a hand on other issues :) |
Contributor
|
just one clippy failure and then should be good to review+merge @eagr =) |
Contributor
|
and now |
Contributor
Author
|
have been away from rust for a while. I have the commands set up again, it will be smoother next time :)) |
sam0x17
approved these changes
Oct 11, 2024
unconst
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #841
Description
Add custom lint to forbid certain
as_*()conversions to avoid accidental panics.Type of Change