Merged
Conversation
sam0x17
previously approved these changes
Oct 21, 2024
Contributor
sam0x17
left a comment
sam0x17
left a comment
There was a problem hiding this comment.
looks good to me, one possible edge case to consider is testing reveals in highly concurrent environments or simultaneous commits from multiple hotkeys
also consider documenting the rationale for enforcing specific batch reveal orders just to make it clearer for users
orriin
reviewed
Oct 23, 2024
JohnReedV
requested review from
distributedstatemachine,
gztensor,
open-junius and
orriin
orriin
approved these changes
Oct 24, 2024
unconst
approved these changes
Oct 24, 2024
sam0x17
approved these changes
Oct 24, 2024
open-junius
reviewed
Oct 25, 2024
| 0 | ||
| } | ||
| #[pallet::type_value] | ||
| /// Default minimum stake for weights. |
open-junius
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)