get stake interface in solidity#955
Merged
sam0x17 merged 16 commits intodevnet-readyfrom Jan 14, 2025
Merged
Conversation
orriin
reviewed
Nov 13, 2024
Contributor
orriin
left a comment
There was a problem hiding this comment.
Looks good, can we get a test?
Contributor
Author
|
2 tasks
2 tasks
5 tasks
5 tasks
Contributor
|
Please implement the e2e test for this as a separate test and let it fail. When we merge to devnet-ready, the tests will be passing. |
Contributor
Author
|
https://github.com/opentensor/subtensor-js-tests/blob/main/src/evm/eth.staking.precompile.test.js#L215 separate test case is added. |
|
It would be great to have this merged ! Thanks for this PR. |
sam0x17
approved these changes
Dec 18, 2024
sam0x17
previously approved these changes
Jan 2, 2025
gztensor
previously approved these changes
Jan 2, 2025
camfairchild
suggested changes
Jan 2, 2025
Contributor
|
Needs the |
Contributor
Author
Will update it after RAO feature merged. Now, we can use the netuid in nowhere. |
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
sam0x17
approved these changes
Jan 14, 2025
This was referenced Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR add the stake data access in solidity precompile contract.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.