Skip to content

Remove unnecessary generics#979

Merged
sam0x17 merged 3 commits intodevnet-readyfrom
feat/clean-up-node-crate
Nov 15, 2024
Merged

Remove unnecessary generics#979
sam0x17 merged 3 commits intodevnet-readyfrom
feat/clean-up-node-crate

Conversation

@ales-otf
Copy link
Contributor

@ales-otf ales-otf commented Nov 13, 2024

Description

Cleans up the node from unnecessary type parametrizations.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): chore

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ales-otf ales-otf marked this pull request as ready for review November 13, 2024 20:10
@ales-otf ales-otf requested a review from unconst as a code owner November 13, 2024 20:10
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@sam0x17 sam0x17 requested a review from a team November 13, 2024 22:10
@sam0x17 sam0x17 merged commit 5bcb978 into devnet-ready Nov 15, 2024
@ales-otf ales-otf deleted the feat/clean-up-node-crate branch November 15, 2024 18:29
@ales-otf ales-otf self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants