Merged
Conversation
Contributor
Eugene-hu
commented
Jul 26, 2023
Eugene-hu
commented
- Adds an additional relevancy filter
- The filter will live on top of the current filter
- Updates version to 1.1.2
Eugene-hu
requested review from
isabella618033,
opentaco,
p-ferreira,
shibshib,
steffencruz and
unconst
opentaco
approved these changes
Jul 26, 2023
isabella618033
approved these changes
Jul 26, 2023
Contributor
isabella618033
left a comment
isabella618033
left a comment
There was a problem hiding this comment.
LGTM!
later on, we should add individual rewards to the wandb logging as well
| BertRelevanceRewardModel(self.device), | ||
| MpnetRelevenceModel(self.device) | ||
| ] | ||
| self.bounds = [-0.0246, 0.3] |
Contributor
There was a problem hiding this comment.
should we change it into a lower bound?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.