[hotfix] bump datasets pin to fix python compat#109
Merged
Conversation
ifrit98
changed the title
ifrit98
changed the title
ifrit98
requested review from
Eugene-hu,
isabella618033,
p-ferreira and
shibshib
camfairchild
approved these changes
Jul 26, 2023
camfairchild
approved these changes
Jul 27, 2023
Eugene-hu
reviewed
Jul 31, 2023
requirements.txt
Outdated
| transformers<=4.28.0 | ||
| wandb==0.15.3 | ||
| datasets==2.12.0 | ||
| datasets>=2.14.0 |
Contributor
There was a problem hiding this comment.
Is there a reason that we moved from a strict == version requirement to a loose one? Personally, I think it's a better practice to pin the version or a limited set of version with <= so that we are unaffected by sudden new releases of dataset. What do you think?
ifrit98
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a new issue (3 days old) with python updating multiprocessing for python 3.11 support. Borks all fresh python (any version) installs of bittensor as datasets was pinned at a lower version.
Does 2 things:
2.14.0.5.2.1(hotfix for this issue)See bittensor release 5.2.1
opentensor/bittensor#1468