Skip to content

version 1.0.4 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eugene-hu merged 2 commits into from
Jun 9, 2023
Merged

version 1.0.4 #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eedbb88
version 1.0.3
Eugene-hu Jun 9, 2023
11de06a
v.1.0.4
Eugene-hu Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions openvalidators/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,6 @@
from . import utils
from . import weights

__version__ = "1.0.2"
__spec_version__ = 1003
__version__ = "1.0.4"
version_split = __version__.split(".")
__spec_version__ = (1000 * int(version_split[0])) + (10 * int(version_split[1])) + (1 * int(version_split[2]))
Copy link
Contributor

@isabella618033 isabella618033 Jun 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it still work if the sub version is >= 10? xd
eg. 1.0.35 -> 1035
1.3.5 -> 1035

Copy link
Contributor Author

@Eugene-hu Eugene-hu Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, so v1.35.0 would work, but not 1.0.35

Copy link
Contributor

@steffencruz steffencruz Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point, but as the authors and maintainers we should hold ourselves responsible for the conventions we keep.

There should be an agreed upon limit to the sub version fields. If we are going to exceed 10 revisions (0-9) we should use different prefactors such as 10,000, 100, 1